dashersw / pedalboard.js

Open source JavaScript framework for developing audio effects for guitars using the Web Audio API.
dashersw.github.com/pedalboard.js
GNU General Public License v3.0
831 stars 97 forks source link

Add Firefox support for pedalboard.js #7

Closed ehsan closed 10 years ago

ehsan commented 11 years ago

I've been working on adding Web Audio support in Firefox, you can try it out in Firefox Nightly http://nightly.mozilla.org/. I think we should support everything that this code needs by now, except for ConvolverNode which I'm currently working on (should be in Firefox Nightly in the next few days.)

Supporting Firefox should hopefully be a matter of using AudioContext instead of webkitAudioContext.

dashersw commented 11 years ago

Thanks for the info! I'll check it out tonight and update accordingly.

ehsan commented 11 years ago

Great, let me know if something doesn't work as you expected in Firefox.

dashersw commented 11 years ago

Hello, createMediaStreamSource of AudioContext is currently unimplemented I guess. It disables StreamInput (which gets the user's line-in for pedal input).

dashersw commented 11 years ago

The only other problem is Firefox not being able to decode MP3 files on Macs (samples were MP3's).

Other than that, it works. Great work! Thank you!

If you would kindly let me know when these are implemented, I will gladly support Firefox out of the box.

dashersw commented 10 years ago

@ehsan, Pedalboard.js fully supports Firefox as of 0.4.0.