fix: `getStatus` wrong hashes serialization - Githubissues

dashevo / dapi

DEPRECATED A decentralized API for the Dash network

MIT License

17 stars 11 forks source link

fix: `getStatus` wrong hashes serialization #362

Closed antouhou closed 3 years ago

antouhou commented 3 years ago

Issue being fixed or feature implemented

Hashes in getStatus response being serialized the wrong way

What was done?

Added proper conversion to binary

How Has This Been Tested?

Modified existing test to ensure that fields that supposed to be binaries are binaries

Breaking Changes

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone