fix: subscribeToNewTransactions doesn't emit instant lock in some cases - Githubissues

dashevo / dapi

DEPRECATED A decentralized API for the Dash network

MIT License

17 stars 11 forks source link

fix: subscribeToNewTransactions doesn't emit instant lock in some cases #384

Closed shuplenkov closed 3 years ago

shuplenkov commented 3 years ago

Issue being fixed or feature implemented

In some rare cases, instant locks are not emitted in subscribeToNewTransactions endpoints, which leads to timeouts errors in dashmate

What was done?

Removed unnecessary Core RPC calls
Buffer instant locks while mempool and historical transactions are sending

How Has This Been Tested?

By running Dashmate

Breaking Changes

No

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone