feat!: use semantic error codes - Githubissues

dashevo / dapi

DEPRECATED A decentralized API for the Dash network

MIT License

17 stars 11 forks source link

feat!: use semantic error codes #397

Closed shumkov closed 3 years ago

shumkov commented 3 years ago

Issue being fixed or feature implemented

To allow more logical error handling for clients, we need to use semantically correct error codes for different cases.

What was done?

Use NotFound, FailedPrecondition, and InvalidArgument in places where it makes sense

How Has This Been Tested?

With tests

Breaking Changes

Some endpoints respond with different error codes

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone