feat: respond with Drive's error data in metadata - Githubissues

dashevo / dapi

DEPRECATED A decentralized API for the Dash network

MIT License

17 stars 11 forks source link

feat: respond with Drive's error data in metadata #406

Closed shumkov closed 3 years ago

shumkov commented 3 years ago

Issue being fixed or feature implemented

Drive's error data is sent as JSON in gRPC metadata so it can't be restored by client. Also, arguments for DPP consensus errors weren't sent at all.

What was done?

Drive's error data cbored to drive-error-data-bin gRPC metadata field

How Has This Been Tested?

With test

Breaking Changes

None

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone