dashevo / dashmate

DEPRECATED Distribution package for Dash Masternode installation

MIT License

11 stars 12 forks source link

fix: various sentinel container errors on full nodes #440

Closed strophy closed 3 years ago

strophy commented 3 years ago

Issue being fixed or feature implemented

270 Sentinel should not be started on full nodes, and should not be included in status output in `status:core` if it can never return a good status.

What was done?

Moved sentinel into a separate compose file
Put conditions around sentinel status checks, so they only run on masternodes

How Has This Been Tested?

Locally on testnet

Breaking Changes

None

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

strophy commented 3 years ago

Thanks, I had been using this notation everywhere in the status command, so now it is fixed everywhere 🚀