fix: `$id` and `$ownerId` are not converted to identifiers - Githubissues

dashevo / js-dash-sdk

DEPRECATED Dash client-side library for wallet payment/signing and application development. (Wallet, DAPI, Primitives, BLS, ...)

https://dashevo.github.io/platform/SDK/

MIT License

36 stars 21 forks source link

fix: `$id` and `$ownerId` are not converted to identifiers #148

Closed shumkov closed 3 years ago

shumkov commented 3 years ago

Issue being fixed or feature implemented

In #145 we supposed to convert identifiers in where conditions from strings to buffers but system properties $id and $ownerId are not covered.

What was done?

Convert system properties $id and $ownerId from strings to buffers in the documents.get's where option.

How Has This Been Tested?

With unit test

Breaking Changes

None

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone