feat!: convenient broadcast errors - Githubissues

dashevo / js-dash-sdk

DEPRECATED Dash client-side library for wallet payment/signing and application development. (Wallet, DAPI, Primitives, BLS, ...)

https://dashevo.github.io/platform/SDK/

MIT License

36 stars 21 forks source link

feat!: convenient broadcast errors #266

Closed shumkov closed 2 years ago

shumkov commented 2 years ago

Issue being fixed or feature implemented

Provide detailed error information for the broadcast state transition method, including DAPI/Drive common errors and DPP consensus errors.

What was done?

Throw StateTransitionBroadcastError in case if local basic validation failed
Add DAPI Client and DPP errors as a cause to StateTransitionBroadcastError

How Has This Been Tested?

With tests

Breaking Changes

StateTransitionBroadcastError#getData is removed. Use StateTransitionBroadcastError#getCause to get additional details.

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone