fix: `stream.cancel` leading to double-free and segfault - Githubissues

dashevo / js-dash-sdk

DEPRECATED Dash client-side library for wallet payment/signing and application development. (Wallet, DAPI, Primitives, BLS, ...)

https://dashevo.github.io/platform/SDK/

MIT License

36 stars 21 forks source link

fix: `stream.cancel` leading to double-free and segfault #275

Closed jawid-h closed 2 years ago

jawid-h commented 2 years ago

Issue being fixed or feature implemented

Due to a bug in grpc-js explained here. A temporary solution is used to bypass this bug until a fix is merged into Node.js explained here

What was done?

wrapped up stream.cancel into setImmediate

How Has This Been Tested?

Breaking Changes

None.

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone