fix: DPNS contract and owner ID envs are strings - Githubissues

dashevo / js-dpp

DEPRECATED The JavaScript implementation of the Dash Platform Protocol

MIT License

8 stars 8 forks source link

fix: DPNS contract and owner ID envs are strings #267

Closed shumkov closed 4 years ago

shumkov commented 4 years ago

Issue being fixed or feature implemented

DPNS contract ID and owner ID accepted from envs as stings and comparing with Buffers so data triggers never applied to DPNS contract documents.

What was done?

Covert DPNS contract ID and owner ID envs to Identifiers
Change data contract ID comparison from === to Buffer#equals
Remove unused rejectUpdateDataTrigger

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone