perf!: limit publicKeys items to 32 - Githubissues

dashevo / js-dpp

DEPRECATED The JavaScript implementation of the Dash Platform Protocol

MIT License

8 stars 8 forks source link

perf!: limit publicKeys items to 32 #278

Closed Cofresi closed 3 years ago

Cofresi commented 3 years ago

Issue being fixed or feature implemented

In order to prevent users from creating identities with a large number of publicKeys keys this limits publicKeys to max 32

What was done?

changed maxItems from 100 to 32

How Has This Been Tested?

Unit tests and integration tests pass

Breaking Changes

This is a breaking change, as it limits an existing interface. But it shouldn't affect any existing integrations.

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone