fix!: protocol version was missing from binary data for data contract - Githubissues

dashevo / js-dpp

DEPRECATED The JavaScript implementation of the Dash Platform Protocol

MIT License

8 stars 8 forks source link

fix!: protocol version was missing from binary data for data contract #330

Closed jawid-h closed 3 years ago

jawid-h commented 3 years ago

Issue being fixed or feature implemented

Fixing missing protocolVersion that should've been prepended in toBuffer of DataContract in following PR (#325)

What was done?

prepend protocolVersion in toBuffer of DataContract

How Has This Been Tested?

Unit tests

Breaking Changes

Previously serialized data is not compatible.

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone