feat!: create an error instance from code and required data - Githubissues

dashevo / js-dpp

DEPRECATED The JavaScript implementation of the Dash Platform Protocol

MIT License

8 stars 8 forks source link

feat!: create an error instance from code and required data #342

Closed shumkov closed 3 years ago

shumkov commented 3 years ago

Issue being fixed or feature implemented

To pass only necessary data to the client and allow to recreate error instances from a code and additional required information we should implement:

Errors require only minimal necessary information
DPP provides a method to create an error from a code and the required info
Errors provide a method to extract this information

What was done?

Added missing consensus errors
Passed only necessary information to consensus error constructors, additional information (for logging) added with setters
Added AbstractConsensusError#getConstructorArguments() method to return information necesarry to reinstantiate an error
Made ConsensusError class abstract
Implemented createConsenusError function
Test error codes

How Has This Been Tested?

With integration and unit tests

Breaking Changes

Some validation errors are changed.

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone