dashhive / DashWallet.js

A more civilized DASH Wallet SDK for a less civilized age (Browser, Node.js, & Bundler compatible)
MIT License
3 stars 2 forks source link

Zephira feedback. #21

Open ZephiraDev opened 1 year ago

ZephiraDev commented 1 year ago

DASH INCUBATOR - TEST DASH JS WALLET @ https://github.com/dashhive/wallet.js/


VIRTUAL_MACHINE:

-ubuntu 20.04.3 LTS Server -npm 8.18.2 -nodejs v18.12.1

DEPLOYMENT_PROVISIONING:

-virtualbox 6.1 -vagrant 2.2.19 -ansible core 2.13.7 -python 3.8.10 -git version 2.25.1


Installment was easy and straightforward. after installing required packages git, nodejs and npm, perform git clone and run "npm intall". this will install the required packages for the command line javascript wallet. these can be found in the package.json file. dashwallet.js is executable from command line in the bin direcory. Run node wallet.js for an overview of command line calls. Output :

node wallet.js

Usage: wallet balances wallet export [./dir/ or ./file.wif] wallet friend [xpub-or-static-addr] wallet generate address wallet import <./path/to.wif> wallet list [--sort wallet,amount,addr] [--json] wallet pay <handle|pay-addr> [--dry-run] [--coins Xxxxx:xx:0,...] wallet remove [--no-wif] wallet stat wallet sync wallet version

Global Options: --config-dir ~/.config/dash/ --sync # wait for sync first

Alternatively you can run node wallet {command} in the binary directory example :

node wallet generate address

configuration, as stated to be found in the config-dir. Adresses and private keys generated with the wallet can be found there in json format (private-wallets.json) So far I enjoy using the wallet and it all works out of the box. easy to set up even for someone who has never used nodejs and generally I don't like javascript as a whole. However this experience was nice. The code reads through easily and understandable too. I will continue some more testing and later on thanks for reading.

Suggestionst thus far: Maybe something in the /docs folder which is empty. Though I doubt any real developer needs docs to get this runnnig and understand it.

thoughts I see that the address and private key pair is saved in a non encrypted way in the json file private-wallets.json. do we need to encrypt this and make the data only available through authenticated wallet.js calls?

I will add more information later