search

dashingrocket / simplecov-cobertura

Ruby SimpleCov Cobertura Formatter
Apache License 2.0
52 stars 38 forks source link

Replace libxml-ruby with REXML for a pure-Ruby experience #1

Closed sczizzo closed 8 years ago

sczizzo commented 8 years ago

Looks like this gem depends libxml-ruby, which requires libxml and C extensions, so it's not possible to use this gem with JRuby. I was able to replace the libxml-ruby dependency with REXML, which is pure Ruby and included in Ruby's standard library. The tests still rely on libxml-ruby, but the lib itself does not.

jessebs commented 8 years ago

Have you tried updating the tests to use it REXML well?

sczizzo commented 8 years ago

REXML actually doesn't do validation against a DTD. AFAIK there are no pure Ruby implementations of this :/

jessebs commented 8 years ago

I made a couple of clean-up type comments to the PR. Once you get those in place, I'll merge it in. Thanks for the work on this!

jessebs commented 8 years ago

Merged. Thank you for your contribution!

sczizzo commented 8 years ago

No problem, thanks for the tool!

jessebs commented 8 years ago

1.0.3 has been pushed with your changes. I converted the tests to use nokogiri for dtd validation, so it is now testable in jruby as well.