search

dashingrocket / simplecov-cobertura

Ruby SimpleCov Cobertura Formatter
Apache License 2.0
52 stars 38 forks source link

Fixes #10 - Adds coverage output in terminal #11

Closed pramodshinde closed 3 years ago

pramodshinde commented 4 years ago

Is this a legitimate? 

Coverage report generated for RSpec to /app/coverage/coverage.xml 4605 / 15634 LOC (29.46%) covered.
Coverage report generated for RSpec to /app/coverage. 4605 / 15634 LOC (29.46%) covered
jessebs commented 4 years ago

Thank you very much! A couple of small things. Could you add a period after the coverage.xml in the output to make it consistent with the output of the default formatter? And what do you think about writing a unit test for the output? https://stackoverflow.com/a/22777806/1449987 might be a good reference.

pramodshinde commented 4 years ago

@jessebs Sure will address requested suggestions

jessebs commented 4 years ago

Thank you, @pramodshinde . I'm looking forward to merging it in.

pramodshinde commented 3 years ago

@jessebs Addressed all the suggestions and amended changes