search

dashingrocket / simplecov-cobertura

Ruby SimpleCov Cobertura Formatter
Apache License 2.0
52 stars 38 forks source link

Fix CI errors #21

Closed st0012 closed 2 years ago

st0012 commented 2 years ago
  1. Newer simplecov versions use "lines" as key to retrieve line data, which causes TypeError: no implicit conversion of String into Integer in Ruby 2.5+ tests.
  2. After Ruby 3.0, rexml is no longer a default gem and needs to be installed separately. So we should declare it as a dependency.
  3. Avoid using root path for testing. In newer SimpleCov versions, assigning root path to SimpleCov.root will cause it to create a directory there, which would cause permission denied error.
st0012 commented 2 years ago

The failed specs are on Ruby 1.9 and 2.0, which's support can be removed imo. Feel free to close this if those versions still need to be supported.

jessebs commented 2 years ago

Thank you for your contribution. I'm merging this in. I'm actually going to drop support of ruby <2.5 at this time, so no worries about the failed builds