XML Version - Githubissues

dashingrocket / simplecov-cobertura

Ruby SimpleCov Cobertura Formatter

Apache License 2.0

52 stars 38 forks source link

XML Version #4

Closed rlester closed 7 years ago

rlester commented 7 years ago

For conistency sake converted all single quotes in coverage.xml to double quotes.
Added XML version header.

jessebs commented 7 years ago

Thank you very much for the pull request. It looks like none of the build failures are a direct result of your change. I will review your change in more detail and will merge in the next few days if I don't find anything concerning.

rlester commented 7 years ago

Sounds good, let me know if you need any clarification.

rlester commented 7 years ago

@jessebs Any update on the review?

jessebs commented 7 years ago

Not yet. I'll have it done by the end of this weekend.

jessebs commented 7 years ago

No issues will the pull request. All merged in and a new version has been pushed to rubygems - version 1.2.0.

rlester commented 7 years ago

@jessebs Thanks you!