search

dashingrocket / simplecov-cobertura

Ruby SimpleCov Cobertura Formatter
Apache License 2.0
52 stars 38 forks source link

Relax JSON dependency to allow 2.x #5

Closed isuda closed 6 years ago

isuda commented 6 years ago

Simplecov also changed this a while ago:

https://github.com/colszowka/simplecov/commit/b47a3bd33d70f90ea2339ec2cef2c7427a6cb825

jesperronn commented 6 years ago

Until this is merged, I cannot update my application to Ruby 2.4 since Ruby 2.4 defaults json to 2.0.4 (I'm using Ruby 2.4.2)

jesperronn commented 6 years ago

The build (run 94) is failing with this message:

  bundle install --gemfile=$SHIPPABLE_GEMFILE $SHIPPABLE_BUNDLER_ARGS 2s  
Fetching gem metadata from https://rubygems.org/.............
Fetching version metadata from https://rubygems.org/.
nokogiri-1.8.1 requires ruby version >= 2.1.0, which is incompatible with the
current version, ruby 1.9.3p551

So, if simplecov-cobertura depends on nokogiri, the 1.9 dependencies should probably be handled in a separate gemfile?

jessebs commented 6 years ago

I should have time this weekend or coming week to merge it in. I'll also evaluate the comment from @denispasin as to whether we even need the dependency.

zaratan commented 6 years ago

I tested it there ( https://github.com/denispasin/simplecov-cobertura/blob/master/simplecov-cobertura.gemspec ) and it worked well

jessebs commented 6 years ago

I took the discussion points here and created a new pull request #6