Refactor + Possibility to remove title

dashnine / PaperBlossoms

A character generator for Legend of the Five Rings (FFG)

GNU General Public License v3.0

42 stars 15 forks source link

Refactor + Possibility to remove title #228

Closed MJKruszewski closed 2 years ago

MJKruszewski commented 2 years ago

Would be nice to merge this before new DLC

dashnine commented 2 years ago

Hey! Exciting. I'll take a look :)

dashnine commented 2 years ago

I did a static review of the changes! I see what you were aiming for here. :) While I don't know if I necessarily like the DatabaseDependency and Repository naming scheme exactly, I don't have an immediate better name. :) Otherwise, this all looks reasonable; I'm going to create a refactor branch and merge into that for testing, and I'll move it into master once I've had a little time to put it through its paces!

dashnine commented 2 years ago

I've merged refactor_22 into master!