go-bindings: Initial version

dashpay / bls-signatures

BLS signatures in C++, using the relic toolkit

Apache License 2.0

10 stars 34 forks source link

go-bindings: Initial version #8

Closed xdustinface closed 3 years ago

xdustinface commented 4 years ago

This PR adds the initial version of the Go bindings for our library into the folder ./go-bindings. Its based on the implementation of @nmarley which is added in here with the commit af5b6be39787100a87ba1054ebf9f9b4cafc4a57. The remaining commits contain the following adjustments i made:

Make the bindings working in our repo together with our latest develop branch.
Fix the segmentation fault issue we randomly run into during tenderdash tests: 88d8205feb3c2d4b03728ecbb034dbe471b886a9 + e81ca065203ad6a5d9ce8962a16a12580ff8fa7a
Add util.go with some helpers and llmq_example_test.go which contains a LLMQ threshold signing test around this example data.
Add missing and some additional binding calls.
Some general fixes/improvements.

Requires #5 to pass all tests

xdustinface commented 4 years ago

@QuantumExplorer the runtime.KeepAlive calls are only required for the C-allocated objects added to runtime.SetFinalizer the ones you pointed out are normal Go objects.

PastaPastaPasta commented 4 years ago

@nmarley Do you think it'd be possible for you to review this?

I don't think I have the adequate skills in order to give this PR a proper review

nmarley commented 4 years ago

@PastaPastaPasta Yes, I'd be happy to review. Might be a day or two before I get done.

xdustinface commented 4 years ago

Last commits adding some more bindings and tests related to Signature/PublicKey/PrivateKey shares and recovery.

@nmarley Could you make any review progress so far? 🙂

nmarley commented 4 years ago

@xdustinface Hey! Yeah I'm currently about 33% of the way thru, at commit e81ca06. I'll probably have some questions for you but will leave them on here.

UdjinM6 commented 3 years ago

cpp side of things looks sane imo (and that's probably the best review I can give to this kind of PRs 🙈 ), so utACK from me.

@nmarley @QuantumExplorer could you guys pls review the rest of it and give it a formal (ut)ACK (if all is looking ok-ish ofc)?

QuantumExplorer commented 3 years ago

I've been using this branch and all seemed to work well. Though not extensively yet. I also reviewed things and all looks good @UdjinM6

nmarley commented 3 years ago

LGTM 👍

utACK @ c7ad299