search

dashpay / dash-evo-tool

A tool to interact with Evolution
MIT License
4 stars 2 forks source link

fix: update identity after registering name instead of reinserting #41

Closed pauldelucia closed 2 weeks ago

pauldelucia commented 2 weeks ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request encompasses significant updates across multiple files, primarily enhancing the "Release Dash Evo Tool" workflow, restructuring dependencies, and introducing new functionalities for identity and wallet management. Key changes include the addition of permissions in workflow configurations, modifications to dependency management in Cargo.toml, and the introduction of new ZeroMQ publishing options in configuration files. Furthermore, various UI components and methods have been refined or added to improve the user experience and facilitate better management of identities and wallet functionalities.

Changes

File Change Summary
.github/workflows/release.yml Added permission contents: write, specified runs-on for Windows to "ubuntu-20.04", streamlined protoc installation commands.
Cargo.toml Removed enum_dispatch, added directories, zmq, zeroize, zxcvbn, argon2, and aes-gcm, updated serde_yaml.
dash_core_configs/mainnet.conf Added ZMQ options: zmqpubrawtxlocksig=tcp://0.0.0.0:23708, zmqpubrawchainlock=tcp://0.0.0.0:23708.
dash_core_configs/testnet.conf Added ZMQ options: zmqpubrawtxlocksig=tcp://0.0.0.0:23709, zmqpubrawchainlock=tcp://0.0.0.0:23709.
src/app.rs Enhanced AppState with new ZMQ listener fields, updated message handling logic, added WithdrawalStatus enum variant.
src/app_dir.rs Added functions for managing application data directories.
src/backend_task/contested_names/mod.rs Updated import for BackendTaskSuccessResult, modified task handling logic.
src/backend_task/contested_names/query_dpns_vote_contenders.rs Renamed parameter sender to _sender in method signature.
src/backend_task/contested_names/query_ending_times.rs Renamed parameter sender to _sender in method signature.
src/backend_task/contested_names/vote_on_dpns_name.rs Corrected import path for BackendTaskSuccessResult.
src/backend_task/core/mod.rs Introduced CoreTask and CoreItem enums, added run_core_task method.
src/backend_task/core/refresh_wallet_info.rs Added refresh_wallet_info method for wallet updates.
src/backend_task/document.rs Updated import for BackendTaskSuccessResult, refined document task execution logic.
src/backend_task/identity/*.rs Multiple updates to methods and signatures to enhance identity management, including changes to return types and error handling.
src/database/*.rs Introduced new methods for managing asset lock transactions, identities, and wallet data, along with schema updates in initialization.
src/ui/*.rs Major updates to UI components, including new screens for wallet management, identity registration, and withdrawal statuses.
src/ui/mod.rs Updated module declarations to reflect new screen types and functionalities.

Possibly related PRs

Suggested reviewers

Poem

🐰 In the meadow where code does play,
New features bloom, brightening the day.
With ZMQ whispers and workflows refined,
Our Dash Evo Tool is one of a kind!
Hops of joy as we build and release,
In this rabbit's heart, there's only peace! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.