search

dashpay / dash-evo-tool

A tool to interact with Evolution
MIT License
4 stars 2 forks source link

feat: custom dash-qt path and conf #73

Closed ogabrielides closed 1 day ago

ogabrielides commented 4 days ago

In the Network Chooser Screen, possibility to:

Both settings are persistent in database. Database version was bumped to 3 and migration queries were added.

Summary by CodeRabbit

Release Notes

These updates improve user experience and flexibility when configuring Dash-QT settings.

coderabbitai[bot] commented 4 days ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces several updates across multiple files, primarily focusing on enhancing the application settings and database initialization. Key changes include the addition of a new dependency in Cargo.toml, modifications to the AppState struct to accommodate new settings fields, and updates to the CoreTask enum and associated methods to handle additional parameters. The database initialization logic is also updated to support a new schema version, including new columns for settings. Overall, these changes enhance the configuration options for the Dash-QT application.

Changes

File Path Change Summary
Cargo.toml Added new dependency: rfd = "0.15.1".
src/app.rs Expanded settings tuple in AppState from three to five elements; updated new method.
src/backend_task/core/mod.rs Updated StartDashQT variant in CoreTask enum to include two new parameters.
src/backend_task/core/start_dash_qt.rs Modified start_dash_qt method to accept new parameters and adjusted logic for starting Dash-Qt.
src/context.rs Updated get_settings method signature to include new fields.
src/database/initialization.rs Incremented DEFAULT_DB_VERSION to 3; added migration logic for new version.
src/database/settings.rs Added methods to update settings and alter the database schema; modified get_settings method.
src/ui/components/top_panel.rs Enhanced add_connection_indicator to utilize new settings for starting DashQT.
src/ui/network_chooser_screen.rs Added new fields to NetworkChooserScreen struct; updated methods to handle custom Dash-QT configurations.

Possibly related PRs

Suggested reviewers

Poem

🐇 In the garden of code, we hop with delight,
New paths for Dash-QT, shining so bright.
With settings expanded, our options now bloom,
Custom paths and flags, dispelling the gloom.
So let’s start the journey, with joy we will sing,
For every new feature, a dance of the spring! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
ogabrielides commented 4 days ago

@coderabbitai review

coderabbitai[bot] commented 4 days ago
:white_check_mark: Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
thephez commented 3 days ago

I got the same error as Paul. In my case it appears to be because it tried starting Core mainnet even though I have testnet selected in DET (and I already had mainnet running).

ogabrielides commented 3 days ago

@thephez @pauldelucia Addressed the issue. Please check again

thephez commented 2 days ago

The issue before was that mainnet and testnet both use the same dash.conf when you are not overwriting, so it was trying to open the same version of dashcore (testnet or mainnet) twice, so I suggest for this PR or a future PR to disable the network selector when not overwriting, and display a general "start network" button - or something like that.

@pauldelucia @ogabrielides It is possible to run both testnet and mainnet with the same conf file, so having select network is still relevant. One button would just run dash-qt (mainnet) and the other would run dash-qt -testnet (starting it in testnet mode). I would rather see the 2 confs in this repo get condensed into one (not in this PR). I believe that unified conf would look like this:

[main]
rpcport=9998
rpcallowip=127.0.0.1/32
rpcuser=dashrpc
rpcpassword=password
server=1
zmqpubrawtxlocksig=tcp://0.0.0.0:23708
zmqpubrawchainlock=tcp://0.0.0.0:23708

[test]
rpcport=19998
rpcallowip=127.0.0.1/32
rpcuser=dashrpc
rpcpassword=password
server=1
zmqpubrawtxlocksig=tcp://0.0.0.0:23709
zmqpubrawchainlock=tcp://0.0.0.0:23709
pauldelucia commented 2 days ago

Oh, perfect. Disregard my previous comment then, and yeah let's do this in another PR. @thephez @ogabrielides