fix: always set associated IP to be true

[ktechmidas]

Issue being fixed or feature implemented

Issue described in PR https://github.com/dashpay/dash-network-deploy/pull/481 - this is a better fix than ignoring lifecycle changes and supersedes that PR

What was done?

Always set associate public IP to true even if we are going to later replace with an EIP. Terraform does not track state changes correctly here (breaking standards with AWS CloudFormation which does but I digress...)

Terraform has a few long standing issues about this:

https://github.com/hashicorp/terraform-provider-aws/issues/343

https://github.com/hashicorp/terraform/issues/9811

How Has This Been Tested?

Devnet

Breaking Changes

Possibly previous networks with HPMNs may need to redeploy.

Checklist:

• [ x] I have performed a self-review of my own code
• [x ] I have commented my code, particularly in hard-to-understand areas
• [x ] I have added or updated relevant unit/integration/functional/e2e tests
• [x ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• [x ] I have assigned this pull request to a milestone

[ktechmidas]

Works for me 👍 But will this result in AWS associating non-EIP public addresses with the instances in addition to the EIPs?

Yes and no, once the EIP gets added the original address goes away. It doesn't really matter in the grand scheme of things