fix: devnets are incorrectly generated with eips enabled - Githubissues

dashpay / dash-network-deploy

Tools for Dash networks deployment and testing

MIT License

21 stars 19 forks source link

fix: devnets are incorrectly generated with eips enabled #489

Closed strophy closed 1 year ago

strophy commented 1 year ago

Issue being fixed or feature implemented

EIPs should only be enabled on testnet or when specified, but configs were generated such that the default true value was applied

What was done?

Generate create_eips: false in terraform config

How Has This Been Tested?

On devnet-absinthe

Breaking Changes

None

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone