changes to fix_firstrunconfig

vivekgsharma commented 5 months ago

Issue being fixed or feature implemented

if it's defined, use it, if not use dashmate_versio
Change firstRunConfig to not error out if something doesn't exist (eg this will fail because mixers is currently not set: let mixerCountYml = Object.keys(ansibleYml.mixers).length;)
For now duplicate has not been handled because js-yaml doesn't directly support ignoring duplicates and added exit in the deploy script so that we can catch the failure.

What was done?

Made changes to deploy script , load_test role to handle dashmaste_branch and firstrunconfig.js to handle the below issues .

How Has This Been Tested?

Breaking Changes

Nothing is breaking

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

ktechmidas commented 4 months ago

This one doesn't work

monotoko@ip-172-31-0-117:~/code/dash-network-deploy$ ./bin/deploy devnet-ouzo TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at firstRunConfig (/home/monotoko/code/dash-network-deploy/lib/configGenerator/firstRunConfig.js:58:30) at main (/home/monotoko/code/dash-network-deploy/bin/firstRun.js:9:9) at Object.<anonymous> (/home/monotoko/code/dash-network-deploy/bin/firstRun.js:15:1) at Module._compile (node:internal/modules/cjs/loader:1105:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10) at Module.load (node:internal/modules/cjs/loader:981:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) at node:internal/main/run_main_module:17:47

vivekgsharma commented 4 months ago

Fixed and tested.

dashpay / dash-network-deploy