dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

[PS] Mixing completion % is wrong #1279

Closed akijuh closed 7 years ago

akijuh commented 7 years ago

v0.12.1.0-348c001 PS mixing completion % is wrong, see the pic.

image

UdjinM6 commented 7 years ago

Well, it depends how you define progress. This is the way it's now: https://github.com/dashpay/dash/blob/v0.12.1.x/src/qt/overviewpage.cpp#L389-L420

akijuh commented 7 years ago

Yep, but real % is 12.6% (101 of 800). If average user see this (48%), its wrong and they complain that.

UdjinM6 commented 7 years ago

12.6% is not real, 12.6% is for the last round only. Average user won't see this bar anymore, it's only available in "advanced ui" mode.

akijuh commented 7 years ago

Ok, is there really need to have a % at all then.

UdjinM6 commented 7 years ago

That's standard OS-defined progress bar. I don't have any % visible on my mac for example. Also you can hover mouse over it and it will show some more %% about each "logical step" of mixing which could be helpful for advanced users.

akijuh commented 7 years ago

Yes, i can see that now, i close this, thanks.