dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

all blocks rejected.. "Couldn't find masternode payment" #149

Closed ghost closed 9 years ago

ghost commented 9 years ago

Darkcoin was working nicely with NOMP until last week. i found ~ 10 blocks per day.. now i get 10 rejected blocks per day ( and no valid block )

so did somesthing change? i run with "-disablesafemode" because of the last network issues.. ( https://github.com/darkcoin/darkcoin/issues/120 )

there is a problem withe the masternode payment.. but debug.log says, that there was such payment thee minutes before the error!?

do we have new network problems or is it a problem with the NOMP software?

nomp: 2015-02-01 12:48:49 [Pool] darkcoin Daemon instance 0 rejected a supposedly valid block

debug.log 2015-02-01 12:45:05 Masternode payment to XtcjFUahAimJNQXcK3n38Rf86XG6AHMZRC 2015-02-01 12:45:05 CreateNewBlock(): total size 16536 2015-02-01 12:48:41 ResendWalletTransactions() 2015-02-01 12:48:49 CheckBlock() : Couldn't find masternode payment(0|174193390) or payee(1|XtcjFUahAimJNQXcK3n38Rf86XG6AHMZRC) nHeight 212868. 2015-02-01 12:48:49 ERROR: CheckBlock() : Couldn't find masternode payment or payee 2015-02-01 12:48:49 ERROR: ProcessBlock() : CheckBlock FAILED

getinfo { "version" : 110014, "protocolversion" : 70054, "walletversion" : 61000, "balance" : 0.00641604, "darksend_balance" : 0.00000000, "blocks" : 212899, "timeoffset" : 1, "connections" : 9, "proxy" : "", "difficulty" : 4012.64433237, "testnet" : false, "keypoololdest" : 1421676479, "keypoolsize" : 1001, "paytxfee" : 0.00000000, "relayfee" : 0.00001000, "errors" : "" }

crosspost: https://github.com/zone117x/node-stratum-pool/issues/104

vertoe commented 9 years ago

Is NOMP paying 37.5% to masternodes?

ghost commented 9 years ago

no.. the last update from june claims they increased the value from 10% to 20% ( https://github.com/zone117x/node-stratum-pool/pull/79 )

so where does that 37.5 come from? will it further change in the future and where is it documented? thank you!

vertoe commented 9 years ago

It's dynamic and should be fixed in NOMP. To fix this temporary, change the value to 37.5% and to fix this for the long term, this are the values required for masternode payment calculation: https://github.com/darkcoin/darkcoin/blob/master/src/main.cpp#L1413

ghost commented 9 years ago

great. thank you! so i will change it at block 227120 to 40% etc.. NOMP develoment is mostly dead! even this official repository: https://github.com/darkcoin/node-stratum-pool will now only produce invalid blocks..

ghost commented 9 years ago

so i have to re-open this.. last night i found 10 blocks, but also 10 blocks were rejected.. same error message..are there further things i need to have in mind?

here https://drk.mn/blocks.html i can see that my accepted blocks are all correct and have 37.5 % ..

ghost commented 9 years ago

no ideas? still many blocks rejected by darkcoin.. :(

{
    "version" : 110123,
    "protocolversion" : 70066,
    "walletversion" : 61000,
    "balance" : 0.00000000,
    "darksend_balance" : 0.00000000,
    "blocks" : 220967,
    "timeoffset" : 0,
    "connections" : 16,
    "proxy" : "",
    "difficulty" : 3502.62540624,
    "testnet" : false,
    "keypoololdest" : 1423779121,
    "keypoolsize" : 1001,
    "paytxfee" : 0.00000000,
    "relayfee" : 0.00001000,
    "errors" : ""
}

.

2015-02-16 06:52:48 Masternode payment to XrRs3nB6VTv4JvMJ8DeEELrMcd2VuByi9W
2015-02-16 06:52:48 CreateNewBlock(): total size 8952
2015-02-16 06:52:48 CheckBlock() : Found masternode payment 220962
2015-02-16 06:52:58 Masternode payment to XrRs3nB6VTv4JvMJ8DeEELrMcd2VuByi9W
2015-02-16 06:52:58 CreateNewBlock(): total size 9144
2015-02-16 06:52:58 CheckBlock() : Found masternode payment 220962
2015-02-16 06:52:59 receive version message: /darkcoinseeder:0.1.2/: version 70$
2015-02-16 06:53:27 CheckBlock() : Found masternode payment 220962
2015-02-16 06:53:27 CheckBlock() : Found masternode payment 220962
2015-02-16 06:53:27 UpdateTip: new best=0000000000081e3a39dbcd1560e35106d814492$
2015-02-16 06:53:27 ProcessBlock: ACCEPTED
2015-02-16 06:53:27 Masternode payment to XeBDWgknngRPTwf9YCD85TX752zCmTHUsb
2015-02-16 06:53:27 CreateNewBlock(): total size 1000
2015-02-16 06:53:27 CheckBlock() : Found masternode payment 220963
2015-02-16 06:53:27 mnw - winning vote  CTxIn(COutPoint(f7b5899578c2ae4ddb0522a$
2015-02-16 06:53:32 keypool reserve 3
2015-02-16 06:53:32 keypool return 3
2015-02-16 06:53:42 Masternode payment to XeBDWgknngRPTwf9YCD85TX752zCmTHUsb
2015-02-16 06:53:42 CreateNewBlock(): total size 1931
2015-02-16 06:53:42 CheckBlock() : Found masternode payment 220963
2015-02-16 06:53:58 Masternode payment to XeBDWgknngRPTwf9YCD85TX752zCmTHUsb
2015-02-16 06:53:58 CreateNewBlock(): total size 2823
2015-02-16 06:53:58 CheckBlock() : Found masternode payment 220963
2015-02-16 06:54:04 Masternode payment to XeBDWgknngRPTwf9YCD85TX752zCmTHUsb
2015-02-16 06:54:04 CreateNewBlock(): total size 3197
2015-02-16 06:54:04 CheckBlock() : Found masternode payment 220963
2015-02-16 06:54:32 keypool reserve 3
2015-02-16 06:54:32 keypool return 3
2015-02-16 06:55:32 keypool reserve 3
2015-02-16 06:55:32 keypool return 3
2015-02-16 06:56:32 keypool reserve 3
2015-02-16 06:56:32 keypool return 3
2015-02-16 06:56:37 CheckBlock() : Couldn't find masternode payment(0|174114640$
2015-02-16 06:56:37 ERROR: CheckBlock() : Couldn't find masternode payment or p$
2015-02-16 06:56:37 ERROR: ProcessBlock() : CheckBlock FAILED
2015-02-16 06:57:32 keypool reserve 3
2015-02-16 06:57:32 keypool return 3
2015-02-16 06:57:52 CheckBlock() : Found masternode payment 220963
2015-02-16 06:57:52 CheckBlock() : Found masternode payment 220963
2015-02-16 06:57:52 UpdateTip: new best=00000000000db0e7808ffd208ade4e5cf5f1ce8$
2015-02-16 06:57:52 ProcessBlock: ACCEPTED
2015-02-16 06:57:53 mnw - winning vote  CTxIn(COutPoint(433021baaa51bdbbd73c030$
eduffield222 commented 9 years ago

Can you send me logs from the server? evan@darkcoin.io

elbereth commented 9 years ago

Maybe update to the latest version 0.11.1.25 with masternode payment exploit fixed? You are running a vulnerable version: "version" : 110123,

ghost commented 9 years ago

ok thank you. i write you evan. i updated my version.. but still rejected block.. very expensive lessons :(

block 221105 failed..

{
    "version" : 110125,
    "protocolversion" : 70066,
    "walletversion" : 61000,
    "balance" : 0.00000000,
    "darksend_balance" : 0.00000000,
    "blocks" : 221108,
    "timeoffset" : 0,
    "connections" : 10,
    "proxy" : "",
    "difficulty" : 2536.25046799,
    "testnet" : false,
    "keypoololdest" : 1423779121,
    "keypoolsize" : 1001,
    "paytxfee" : 0.00000000,
    "relayfee" : 0.00001000,
    "errors" : ""
}

.

2015-02-16 13:15:58 [Pool]      [darkcoin] (Thread 1) Daemon instance 0 rejected a supposedly valid block

.

2015-02-16 13:12:39 CheckBlock() : skipping transaction locking checks
2015-02-16 13:12:39 CheckBlock() : Found masternode payment 221103
2015-02-16 13:12:39 CheckBlock() : skipping transaction locking checks
2015-02-16 13:12:39 CheckBlock() : Found masternode payment 221103
2015-02-16 13:12:39 UpdateTip: new best=000000000000855e0c8282740920cd046b24c6dc2547aabd23d803598e91f686  height=221103  log2_work=60.995303  tx=868771  date=2015-02-16 13:11:43 progress=0.999989
2015-02-16 13:12:39 ProcessBlock: ACCEPTED
2015-02-16 13:12:39 Masternode payment to Xc93sH82sCtfhzZDTWsduzmC9Kxb2jyJ8g
2015-02-16 13:12:39 CreateNewBlock(): total size 7958
2015-02-16 13:12:39 CheckBlock() : skipping transaction locking checks
2015-02-16 13:12:39 CheckBlock() : Found masternode payment 221104
2015-02-16 13:12:41 mnw - winning vote  CTxIn(COutPoint(2b78bd5c2ee76b8ccabb96c0e7e03b0706a0cd8b2f73f503982246ccc74c62dd, 0), scriptSig=) Height 221113 bestHeight 221103
2015-02-16 13:13:32 keypool reserve 3
2015-02-16 13:13:32 keypool return 3
2015-02-16 13:13:47 Masternode payment to Xc93sH82sCtfhzZDTWsduzmC9Kxb2jyJ8g
2015-02-16 13:13:47 CreateNewBlock(): total size 8183
2015-02-16 13:13:47 CheckBlock() : skipping transaction locking checks
2015-02-16 13:13:47 CheckBlock() : Found masternode payment 221104
2015-02-16 13:14:17 CheckBlock() : skipping transaction locking checks
2015-02-16 13:14:17 CheckBlock() : Found masternode payment 221104
2015-02-16 13:14:17 CheckBlock() : skipping transaction locking checks
2015-02-16 13:14:17 CheckBlock() : Found masternode payment 221104
2015-02-16 13:14:17 UpdateTip: new best=00000000001500b3596525f26f1072d92c47a92fe5e778dcd7cd13d701be8027  height=221104  log2_work=60.99531  tx=868774  date=2015-02-16 13:13:32 progress=0.999991
2015-02-16 13:14:17 ProcessBlock: ACCEPTED
2015-02-16 13:14:17 Masternode payment to Xo5TdDPauEdrcsrTvkqqKfgDYJUk3cFYm9
2015-02-16 13:14:17 CreateNewBlock(): total size 1225
2015-02-16 13:14:17 CheckBlock() : skipping transaction locking checks
2015-02-16 13:14:17 CheckBlock() : Found masternode payment 221105
2015-02-16 13:14:18 mnw - winning vote  CTxIn(COutPoint(c079393750920122db2a8997deab0a8b81d2726e6f6122dc79ba20b02d446e1a, 0), scriptSig=) Height 221114 bestHeight 221104
2015-02-16 13:14:32 keypool reserve 3
2015-02-16 13:14:32 keypool return 3
2015-02-16 13:14:33 Masternode payment to Xo5TdDPauEdrcsrTvkqqKfgDYJUk3cFYm9
2015-02-16 13:14:33 CreateNewBlock(): total size 1451
2015-02-16 13:14:33 CheckBlock() : skipping transaction locking checks
2015-02-16 13:14:33 CheckBlock() : Found masternode payment 221105
2015-02-16 13:14:54 Masternode payment to Xo5TdDPauEdrcsrTvkqqKfgDYJUk3cFYm9
2015-02-16 13:14:54 CreateNewBlock(): total size 1971
2015-02-16 13:14:54 CheckBlock() : skipping transaction locking checks
2015-02-16 13:14:54 CheckBlock() : Found masternode payment 221105
2015-02-16 13:15:03 Masternode payment to Xo5TdDPauEdrcsrTvkqqKfgDYJUk3cFYm9
2015-02-16 13:15:03 CreateNewBlock(): total size 2197
2015-02-16 13:15:03 CheckBlock() : skipping transaction locking checks
2015-02-16 13:15:03 CheckBlock() : Found masternode payment 221105
2015-02-16 13:15:09 Masternode payment to Xo5TdDPauEdrcsrTvkqqKfgDYJUk3cFYm9
2015-02-16 13:15:09 CreateNewBlock(): total size 3613
2015-02-16 13:15:09 CheckBlock() : skipping transaction locking checks
2015-02-16 13:15:09 CheckBlock() : Found masternode payment 221105
2015-02-16 13:15:18 Removing inactive masternode 108.61.169.190:9999
2015-02-16 13:15:32 keypool reserve 3
2015-02-16 13:15:32 keypool return 3
2015-02-16 13:15:58 CheckBlock() : skipping transaction locking checks
2015-02-16 13:15:58 CheckBlock() : Couldn't find masternode payment(0|208936068) or payee(1|Xo5TdDPauEdrcsrTvkqqKfgDYJUk3cFYm9) nHeight 221105. 
2015-02-16 13:15:58 ERROR: CheckBlock() : Couldn't find masternode payment or payee
2015-02-16 13:15:58 ERROR: ProcessBlock() : CheckBlock FAILED
2015-02-16 13:16:13 CheckBlock() : skipping transaction locking checks
2015-02-16 13:16:13 CheckBlock() : Found masternode payment 221105
2015-02-16 13:16:13 CheckBlock() : skipping transaction locking checks
2015-02-16 13:16:13 CheckBlock() : Found masternode payment 221105
2015-02-16 13:16:13 UpdateTip: new best=00000000000faf8e936b804ce93cff129df7225ff6484bd786dd4f70abdfe7a8  height=221105  log2_work=60.995317  tx=868780  date=2015-02-16 13:16:05 progress=0.999998
2015-02-16 13:16:13 ProcessBlock: ACCEPTED
2015-02-16 13:16:13 Masternode payment to XapuF6u7U31ZscEkCfbJ7bWaDoB3Zx9Ycu
2015-02-16 13:16:13 CreateNewBlock(): total size 1000
2015-02-16 13:16:13 CheckBlock() : skipping transaction locking checks
2015-02-16 13:16:13 CheckBlock() : Found masternode payment 221106
UdjinM6 commented 9 years ago

Personally, I think this issue has nothing to do with darkcoin itself actually. Lots of pools are running fine with the latest darkcoin version. @buechling I would suggest you to ask community at https://darkcointalk.org/forums/mining.3/ Maybe there is someone who run nomp too and could answer your question on how to setup/fix nomp to make it work properly.

UdjinM6 commented 9 years ago

Not a darkcoin issue. Problem was solved by applying code changes similar to this https://github.com/darkcoin/node-stratum-pool/commit/e598fb0b6b643191304b257e0d8b0f47f8a5d34a https://darkcointalk.org/threads/coiniumserv-pool-for-darkcoin.3480/page-3#post-42803 Can be closed now.