dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

12.2 "mnsync status" has extra comma in output #1623

Closed nmarley closed 6 years ago

nmarley commented 7 years ago

Specifically the line: "IsWinnersListSynced": true,,

{
  "AssetID": 4,
  "AssetName": "MASTERNODE_SYNC_GOVERNANCE",
  "AssetStartTime": 1505364159,
  "Attempt": 8,
  "IsBlockchainSynced": true,
  "IsMasternodeListSynced": true,
  "IsWinnersListSynced": true,,
  "IsSynced": false,
  "IsFailed": false
}
chaeplin commented 7 years ago
dash-cli --version
Dash Core RPC client version v0.12.2.0-33e460f

dash-cli mnsync status
{
  "AssetID": 4,
  "AssetName": "MASTERNODE_SYNC_GOVERNANCE",
  "AssetStartTime": 1505365130,
  "Attempt": 3,
  "IsBlockchainSynced": true,
  "IsMasternodeListSynced": true,
  "IsWinnersListSynced": true,
  "IsSynced": false,
  "IsFailed": false
}

Which version do you have ?

nmarley commented 7 years ago

Looks like 0.12.2.0-6ff7b7a

chaeplin commented 7 years ago

I have tested bamboo version.

coind@redis-01:~/1 $ ./dashcore-0.12.2/bin/dash-cli --version
Dash Core RPC client version v0.12.2.0-6ff7b7a

coind@redis-01:~/1 $ ./dashcore-0.12.2/bin/dash-cli mnsync status
{
  "AssetID": 4,
  "AssetName": "MASTERNODE_SYNC_GOVERNANCE",
  "AssetStartTime": 1505366333,
  "Attempt": 7,
  "IsBlockchainSynced": true,
  "IsMasternodeListSynced": true,
  "IsWinnersListSynced": true,
  "IsSynced": false,
  "IsFailed": false
}
nmarley commented 7 years ago

This is Bamboo version also. What version is your dashd?

chaeplin commented 7 years ago
coind@redis-01:~ $ uname -a
Linux redis-01 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt20-1+deb8u3 (2016-01-17) x86_64 GNU/Linux
coind@redis-01:~ $ cat /etc/debian_version 
8.3
coind@redis-01:~ $ ./1/dashcore-0.12.2/bin/dashd --version
Dash Core Daemon version v0.12.2.0-6ff7b7a
nmarley commented 7 years ago

Hmm... Strange. I am running in Docker so maybe that has something to do w/it. Will research more and get back to you.

chaeplin commented 7 years ago

src part is : https://github.com/dashpay/dash/blob/v0.12.2.x/src/rpc/misc.cpp#L153-L165

nmarley commented 6 years ago

This isn't an issue w/me for v0.12.2.3, so assuming some issue on my side.