search

dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

4 translations issues #1661

Open akijuh opened 7 years ago

akijuh commented 7 years ago

  1. Encrypt window buttons are not translated.

  2. Encrypt confirmation window buttons are not translated.

  3. Change password window buttons are not translated.

  4. Unlock wallet window buttons are not translated.

  5. About QT window info text is not translated.

  6. Request payment window InstantSend "Yes/no" info text is not translated.

UdjinM6 commented 7 years ago

1-4, 6 - should be fixed 5 - we do not have control over "about qt", it's a standard one

akijuh commented 7 years ago

Ok, closing.

akijuh commented 7 years ago

@UdjinM6 reopened this.

v0.12.2.0-52cd4d4 (10.10.2017) translations issues

  1. Encrypt window -> 'Cancel' button is not translated.
  2. Encrypt confirmation window -> 'Yes' and 'Cancel' button is not translated.
  3. Change password window -> 'Cancel' button is not translated.
  4. Unlock wallet window -> 'Cancel' button is not translated.
UdjinM6 commented 7 years ago

Can't confirm any of it, all looks good for me (Russian, macos).

akijuh commented 7 years ago

Windows 7 x64, screenshots as proof.

Encrypt window encrypt

Encrypt confirmation window encrypt_confirmation

Change password window change_password_window

Unlock wallet window unlock

akijuh commented 7 years ago

@UdjinM6 I figured it out, i think.

My windows is english version, i think that is the reason for this, do you confirm?

UdjinM6 commented 7 years ago

Hmmm, this shouldn't be the case. It's really weird. I can actually confirm that bamboo binaries have this issue, but I have no such issue with my local build. I'll rebuild local binaries from scratch once again, though I'm pretty sure I already did this AFTER translations were merged, but maybe I'm wrong...

@schinzelh could there be some issues with bamboo cache or smth like that?

schinzelh commented 7 years ago

Hmm, git source shouldn’t be cached durin gitian builds - plus version number contains git commit hash. Do the localization bundles get statically compiled in, or do they end up in some system specific qt datapath? What happens if this path gets cleared on the system?

UdjinM6 commented 7 years ago

Hmm... In my local build About Qt text is also translated and it's not the case for the bamboo build. screen shot 2017-10-10 at 22 04 39 screen shot 2017-10-10 at 22 04 58 So the issue is not about our localization files imo, it's about qt. Looks like there were quite few updates in depends/ for qt in bitcoin core...

UdjinM6 commented 7 years ago

This one sounds close https://github.com/bitcoin/bitcoin/commit/c37ea4d403817c16e6b080d126b0a53c9930154d#diff-5e50ddee0f3ab9f50378a3577075f10f

schinzelh commented 7 years ago

Yep, that makes sense, let’s give it a try.

akijuh commented 7 years ago

Any info / progress about this?

UdjinM6 commented 7 years ago

@akijuh Looks like this issue would require upgrade of the build system in general (https://github.com/dashpay/dash/pull/1692) and bumping qt version. With this in mind, we are postponing this till 12.3 - don't want to break anything right now.

akijuh commented 7 years ago

@UdjinM6 Very good, main point is, it's in the queue to be fixed.

akijuh commented 6 years ago

@UdjinM6 @schinzelh

Any info / progress / consideration about this? 12.3 is coming out next, thought this is not so serious issue.

nmarley commented 6 years ago

@codablock Do you know if this has been added to the develop branch?

(From #1692, looks like a yes, but wanted to check to make sure.)

codablock commented 6 years ago

The commit referenced by UdjinM6 is in develop. Can't however confirm that it fixed the bug as I don't fully understand how to reproduce it.

akijuh commented 6 years ago

@codablock You can reproduce problem like this:

Start new empty wallet. Change your wallet language to something else but english. Restart Goto change password and you see this problem. Or Goto encrypt wallet... Or Goto unlock wallet...

codablock commented 6 years ago

Tried to reproduce it with German as language and the Ok/Cancel buttons were properly translated. But there are other issues now which result from e7a6f79e5a74a58a63311ef02728670fc376a558. Now that "Dash Core" is not hardcoded into some translatable strings anymore, but "%1" is instead used, the strings don't match the contents of the dash_xx.ts files anymore. Not sure if this needs to be manually solved or if our normal translation process would resolve it once started? @UdjinM6

UdjinM6 commented 6 years ago

Local build is ok but not the bamboo one.

Re other strings: yes, we'll have to translate quite a few strings again but that's unrelated imo.

PastaPastaPasta commented 4 years ago

@UdjinM6 is this still an issue or can we close?

UdjinM6 commented 4 years ago

Still an issue in v0.16-rc3, I have no idea why.