WSL fails to build depends if WSL appends Windows path

christiancfifi commented 3 years ago

Describe the issue

Error while building depends on any branch, persisting through a reinstall of WSL and Ubuntu: /bin/sh: 1: Syntax error: "(" unexpected Solved by configuring WSL to not append the Windows path to the Ubuntu path. See bitcoin/bitcoin#10269. Maybe the latest WSL changed the path behaviour. Instead of the proposed fix on bitcoin a much cleaner approach is to add this to /etc/wsl.conf

[interop]
appendWindowsPath=false

Can you reliably reproduce the issue?

Yes

If so, please list the steps to reproduce below:

Reinstall WSL and Ubuntu
Attempt to build any dash branch

Machine specs:

OS: Windows 10 Build 19042

christiancfifi commented 3 years ago

It looks like this is already accounted for when cross-compiling for windows from WSL, but not when building for linux from WSL, which isn't a supported way to build (although outside of this issue building for linux from wsl has been working just fine). So, you can close this or I can add the fix to the windows build docs if you want to keep support for linux builds on WSL.

PastaPastaPasta commented 3 years ago

I think if you'd like to create a PR adding a bit more info to the documentation, we'd be happy to consider it.

kwvg commented 3 years ago

This was already addressed in https://github.com/dashpay/dash/pull/2939 and our documentation is updated (albeit with hazy history) in https://github.com/dashpay/dash/pull/3453. The documentation you're looking for is located in build-cross.md

dashpay / dash