search

dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

Update mount instructions on docker hub #5387

Closed qrest closed 1 year ago

qrest commented 1 year ago

The documentation on https://hub.docker.com/r/dashpay/dashd is suggesting to mount a volume to /dash, which is not correct since v18.1. Instead the volume should be mounted to /home/dash.

Change

docker volume create --name=dashd-data docker run -v dashd-data:/dash --name=dashd-node -d \ -p 9999:9999 \ -p 127.0.0.1:9998:9998 \ dashpay/dashd

to

docker volume create --name=dashd-data docker run -v dashd-data:/home/dash --name=dashd-node -d \ -p 9999:9999 \ -p 127.0.0.1:9998:9998 \ dashpay/dashd

This change was introduced by this commit: https://github.com/dashpay/dash/commit/6699b0228f9fd5885ebe60d2e33e4f678ed77c18

PanderMusubi commented 1 year ago

Can you make a PR for this?

qrest commented 1 year ago

Can you make a PR for this?

The repository (https://github.com/dashpay/docker-dashd) is archived so no I can not.

PanderMusubi commented 1 year ago

Ah, but the docker files live now here https://github.com/dashpay/dash/tree/master/contrib/containers

qrest commented 1 year ago

Right, but the image description is not fetched from there. So I guess the owner of the docker hub account has to change it directly.

PanderMusubi commented 1 year ago

Anybody knows who is that? @kwvg @PastaPastaPasta @strophy

strophy commented 1 year ago

Correct, we looked into setting up automation around this but it wasn't feasible without a paid Docker Hub subscription, so we just do manual updates to those docs for the moment. The page has been updated, sorry for missing this when the change occurred.

Verify here and close issue if resolved please: https://hub.docker.com/repository/docker/dashpay/dashd/general

qrest commented 1 year ago

Thanks, the docker image page is indeed correct now

PanderMusubi commented 1 year ago

The price for a subscription for open source communities is $ 0, see https://www.docker.com/pricing/ @strophy does this help?

PanderMusubi commented 1 year ago

Or is it the functionality that is offered for free isn't sufficient for what you talk about?

strophy commented 1 year ago

This is the price for an individual account, but we have a grandfathered "Docker Free Team" pricing plan that allows basic team features, but limited to 3 users. There has been controversy around this earlier this year, see here for how Docker eventually reversed their decision: https://www.docker.com/developers/free-team-faq/