Next batch of backports related to descriptor wallets.
See related issue to track a progress: https://github.com/dashpay/dash-issues/issues/59
Changes in this PR also used in "hardware signing" feature (coming later)
What was done?
It implements a new rpc sethdseed that is based on bitcoin#12560 and newer related changes.
refactoring to rename hdChain to m_hd_chain (see bitcoin#17681 which is DNM).
Bitcoin backports (some of them uses sethdseed, and requires m_hd_chain to reduce conflicts):
bitcoin/bitcoin#19046
bitcoin/bitcoin#19490
bitcoin/bitcoin#18836
bitcoin/bitcoin#20403
bitcoin/bitcoin#21127
bitcoin/bitcoin#21238
bitcoin/bitcoin#21329
How Has This Been Tested?
Run unit/functional tests.
The backports #18836 and #20403 are heavily modified to adopt wallet_upgradewallet.py to our codebase.
Breaking Changes
N/A
Though, sethdseed implementation is not a final version as it is now, can be removed (superseeded by upgradetohd or got mnemonic-feature and super-seed upgradetohd).
Checklist:
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone
Issue being fixed or feature implemented
Next batch of backports related to descriptor wallets. See related issue to track a progress: https://github.com/dashpay/dash-issues/issues/59 Changes in this PR also used in "hardware signing" feature (coming later)
What was done?
sethdseedthat is based on bitcoin#12560 and newer related changes.hdChaintom_hd_chain(see bitcoin#17681 which is DNM).How Has This Been Tested?
Run unit/functional tests. The backports #18836 and #20403 are heavily modified to adopt
wallet_upgradewallet.pyto our codebase.Breaking Changes
N/A Though,
sethdseedimplementation is not a final version as it is now, can be removed (superseeded byupgradetohdor got mnemonic-feature and super-seedupgradetohd).Checklist: