refactor: remove llmq::CQuorum{BlockProcessor, Manager} globals, move to LLMQContext

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

refactor: remove llmq::CQuorum{BlockProcessor, Manager} globals, move to LLMQContext #6030

Closed kwvg closed 1 month ago

kwvg commented 2 months ago

Breaking Changes

None expected.

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas (note: N/A)
[x] I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
[x] I have made corresponding changes to the documentation (note: N/A)
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

kwvg commented 2 months ago

Placing PR as draft to address CMNHFManager initialization concerns

knst commented 2 months ago

Placing PR as draft to address CMNHFManager initialization concerns

@kwvg let's get merged these 4 commits as a spare PR?

To avoid further conflicts and reduce rebases.

kwvg commented 1 month ago

To avoid further conflicts and reduce rebases.

llmq::CQuorumManager requires a smidge change in the ConnectManagers call to work properly (using get()), preventing a clean separation. Apart, the changes are too trivial to justify a PR. Have pushed updates and am continuing in this PR.

PastaPastaPasta commented 1 month ago

Placing PR as draft to address CMNHFManager initialization concerns

@kwvg let's get merged these 4 commits as a spare PR?

refactor: s/quorum_block_processor/qblockman/g 544484d

refactor: remove llmq::CQuorumBlockProcessor global, move to `LLMQC… 48545cf

refactor: rename leftover quorumBlockProcessor-named args and variables 3ad6957

refactor: s/quorum_manager/qman/g ff10e2c

To avoid further conflicts and reduce rebases.

I think I support this

kwvg commented 1 month ago

Renaming has been removed from this PR