backport: merge bitcoin#23077, #22834, #24165, #24555, #24663, #24205, #24687, #25173, #24991, partial bitcoin#24468 (cjdns support)

kwvg commented 2 months ago

Additional Information

Depends on https://github.com/dashpay/dash/pull/6034
Depends on https://github.com/dashpay/dash/pull/6035
If -proxy= is given together with -noonion then the provided proxy will not be set as a proxy for reaching the Tor network. So it will not be possible to open manual connections to the Tor network for example with the addnode RPC. To mimic the old behavior use -proxy= together with -onlynet= listing all relevant networks except onion.
bitcoin#24165 has been backported before bitcoin#23758 and to account for this, minor changes were made in src/test/net_peer_eviction_tests.cpp (using nTimeConnected instead of m_connected). When backporting bitcoin#23758, these changes will have to be reversed as they won't be covered by the cherry-pick diff.
CJDNS support has been labelled as being introduced in Dash Core 21.0, in line with the milestone designation of the PR. Should develop be used for a new minor/patch release, doc/cjdns.md will have to be modified to reflect the correct version number.

No expected protocol or consensus changes.

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas (note: N/A)
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

github-actions[bot] commented 1 month ago

This pull request has conflicts, please rebase.

github-actions[bot] commented 1 month ago

This pull request has conflicts, please rebase.

kwvg commented 1 month ago

CJDNS has been confirmed to work on Dash Core 32f8fda using CJDNS v22 (f344983) on two nodes following instructions from Bitcoin's cjdns.md.

Marking PR as ready for review.