(RPC) The getpeerinfo RPC no longer returns the addnode field by default. This
field will be fully removed in the next major release. It can be accessed
with the configuration option -deprecatedrpc=getpeerinfo_addnode. However,
it is recommended to instead use the connection_type field (it will return
manual when addnode is true)
(Settings) The sendtoaddress and sendmany RPCs accept an optional verbose=True
argument to also return the fee reason about the sent tx.
(Settings) The -debug=db logging category, which was deprecated in v0.18 and replaced by
-debug=walletdb to distinguish it from coindb, has been removed.
(RPC) To make RPC sendtoaddress more consistent with sendmany the following error
sendtoaddress codes were changed from -4 to -6:
Insufficient funds
Fee estimation failed
Transaction has too long of a mempool chain
Checklist:
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone
Issue being fixed or feature implemented
Regular backports from bitcoin v21
What was done?
How Has This Been Tested?
Run unit/functional tests
Breaking Changes
getpeerinfoRPC no longer returns theaddnodefield by default. This field will be fully removed in the next major release. It can be accessed with the configuration option-deprecatedrpc=getpeerinfo_addnode. However, it is recommended to instead use theconnection_typefield (it will returnmanualwhen addnode is true)sendtoaddressandsendmanyRPCs accept an optionalverbose=Trueargument to also return the fee reason about the sent tx.-debug=dblogging category, which was deprecated in v0.18 and replaced by-debug=walletdbto distinguish it fromcoindb, has been removed.sendtoaddressmore consistent withsendmanythe following errorsendtoaddresscodes were changed from-4to-6:Checklist: