In dash#5904 (bitcoin#21595), one of the loops in ProcessReply is supposed to iterate rows.size() times (which at the time was hardcoded to 3), the backport erroneously set the value to m_networks.size() (which also evaluated to 3) as part of increasing m_networks.size() usage.
As this pull request includes bitcoin#23324, which changes it over to rows.size(), the above has been corrected in a separate commit for documentation purposes.
-addrinfo output
-getinfo output (diamonds are due to rendering limitations of my terminal and are not indicative of the symbols used)
-netinfo output
Breaking Changes
CLI -addrinfo now returns a single field for the number of onion addresses known to the node instead of separate torv2 and torv3 fields, as support for TorV2 addresses was removed from Dash Core in 18.0.
-getinfo has been updated to return data in a user-friendly format that also reduces vertical space.
Checklist
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas (note: N/A)
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation (note: N/A)
[x] I have assigned this pull request to a milestone
Additional Information
Dependency for https://github.com/dashpay/dash/pull/6035
Dependency for https://github.com/dashpay/dash/pull/6031
In dash#5904 (bitcoin#21595), one of the loops in
ProcessReplyis supposed to iteraterows.size()times (which at the time was hardcoded to3), the backport erroneously set the value tom_networks.size()(which also evaluated to3) as part of increasingm_networks.size()usage.As this pull request includes bitcoin#23324, which changes it over to
rows.size(), the above has been corrected in a separate commit for documentation purposes.-addrinfooutput-getinfooutput (diamonds are due to rendering limitations of my terminal and are not indicative of the symbols used)-netinfooutputBreaking Changes
CLI
-addrinfonow returns a single field for the number ofonionaddresses known to the node instead of separatetorv2andtorv3fields, as support for TorV2 addresses was removed from Dash Core in 18.0.-getinfohas been updated to return data in a user-friendly format that also reduces vertical space.Checklist