backport: merge bitcoin#20233, #22627, #22725, #22697, #22740, #22849, #22791, #22848, #22915, #22911, #22974, #20234 (addrman backports) - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

backport: merge bitcoin#20233, #22627, #22725, #22697, #22740, #22849, #22791, #22848, #22915, #22911, #22974, #20234 (addrman backports) #6040

Closed kwvg closed 1 month ago

kwvg commented 1 month ago

Additional Information

Dependency for https://github.com/dashpay/dash/pull/6043
bitcoin#22915 is backported before bitcoin#21850, which is the reason {Dump, Read}PeerAddresses takes in an const ArgsManager& but doesn't do anything with it.
- This will need to be accounted for when backporting bitcoin#21850

Breaking Changes

None expected. No changes to serialization format.

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas (note: N/A)
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation (note: N/A)
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

github-actions[bot] commented 1 month ago

This pull request has conflicts, please rebase.