Closed UdjinM6 closed 4 months ago
amount was introduced in https://github.com/dashpay/dash/pull/3101. Double checked the code and yes, we do pass it around (for compatibility reasons) but it doesn’t affect the sig right now, you can set it to 0 or just skip it completely so it should be optional, not required. We even have a test that uses signrawtransactionwithkey and ignores amount https://github.com/dashpay/dash/blob/master/test/functional/rpc_signrawtransaction.py#L19-L46.
amount
optional
required
signrawtransactionwithkey
NOTE: It might become required for sighashtype with SIGHASH_DIP0143 flag after https://github.com/dashpay/dash/pull/5860 activation.
sighashtype
SIGHASH_DIP0143
kudos to @pshenmic for noticing
Adjust help text
Run tests
n/a
Issue being fixed or feature implemented
amountwas introduced in https://github.com/dashpay/dash/pull/3101. Double checked the code and yes, we do pass it around (for compatibility reasons) but it doesn’t affect the sig right now, you can set it to 0 or just skip it completely so it should beoptional, notrequired. We even have a test that usessignrawtransactionwithkeyand ignoresamounthttps://github.com/dashpay/dash/blob/master/test/functional/rpc_signrawtransaction.py#L19-L46.NOTE: It might become required for
sighashtypewithSIGHASH_DIP0143flag after https://github.com/dashpay/dash/pull/5860 activation.kudos to @pshenmic for noticing
What was done?
Adjust help text
How Has This Been Tested?
Run tests
Breaking Changes
n/a
Checklist: