fix: reset rounds to 0 when tx fee is not 0 - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.19k forks source link

fix: reset rounds to 0 when tx fee is not 0 #6058

Closed UdjinM6 closed 2 weeks ago

UdjinM6 commented 3 weeks ago

Issue being fixed or feature implemented

a coinjoin send with say 10x 1 + 0.001 denom -> 10 denom, and this doesn’t reset rounds to 0

reported by @PastaPastaPasta 👍

What was done?

only real coinjoin tx can be a 0 fee tx with denoms, use that fact to avoid the edge case described above

How Has This Been Tested?

reproduced the issue

Breaking Changes

n/a

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)