dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.19k forks source link

feat: Let addrman handle multiple ports for all networks #6062

Closed UdjinM6 closed 3 weeks ago

UdjinM6 commented 3 weeks ago

Issue being fixed or feature implemented

There is really no need to do have this restriction in addrman, we check AllowMultiplePorts() in connman which should be enough already. We can safely re-align addrman to its upstream implementation as suggested in #6043.

What was done?

Drop port "discrimination" in addrman, remove related tests.

How Has This Been Tested?

Run tests, run dash-qt on mainnet/testnet

Breaking Changes

n/a

Checklist:

UdjinM6 commented 3 weeks ago

It changes the internals of addrman logic so not a refactor imo. feat maybe?