fix: add missing checks for not nullptr in rpc for dash specific code - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.19k forks source link

fix: add missing checks for not nullptr in rpc for dash specific code #6065

Closed knst closed 2 weeks ago

knst commented 3 weeks ago

Issue being fixed or feature implemented

There're some usages of unique pointers in RPC code that are not guarded by non-nullptr checks

What was done?

Added missing CHECK_NON_FATAL and refactored some of them to EnsureConnman and EnsurePeerman

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone