fix: auto backup issue with descriptor wallets for CJ - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

fix: auto backup issue with descriptor wallets for CJ #6090

Closed knst closed 3 months ago

knst commented 3 months ago

Issue being fixed or feature implemented

Qt CoinJoin session has problems (https://github.com/dashpay/dash/pull/5579#pullrequestreview-1912946808):

Autobackup problems
False keypool depletion reporting

https://github.com/dashpay/dash-issues/issues/59

What was done?

Disables check for "remaining keys left" and "auto-backups" for non-legacy wallet.

How Has This Been Tested?

Run unit/functional test Try to run CJ mixing for descriptor wallet.

Breaking Changes

N/A

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

knst commented 3 months ago

The first version of PR fixed GUI, but CoinJoin didn't actually started. Added missing changes to coinjoin/client.cpp, itshould work now.