fix: mixing for partially unlocked descriptor wallets

knst commented 6 days ago

Issue being fixed or feature implemented

As noticed by kwvg, mixing doesn't work with descriptor wallets if do "unlock only for mixing". This PR is aiming to fix this issue. https://github.com/dashpay/dash-issues/issues/59

What was done?

Removed default argument "bool mixing = false" from WalletStorage interface, Refactored a logic of CWallet::IsLocked to make it shorter, clearer and unified with bitcoin.

How Has This Been Tested?

A. Run Dash-Qt with descriptor wallet, run mixing, enter passphrase. The wallet is partially unlocked (for mixing only) - possible to see yellow lock in status. Mixing happens. B. Open "send transaction dialog", try to send a transaction: the app asks password to unlock wallet as expected.

Though, I am not sure how exactly to test that all rpc are indeed locked when descriptor wallet is unlocked for mixing only.

Breaking Changes

N/A

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

knst commented 2 days ago

@kwvg you don't see transaction history for CJ because you have a filter "most common" activated:

kwvg commented 1 day ago

you don't see transaction history for CJ because you have a filter "most common" activated

@knst Odd, it was a clean instance, hadn't activated any filter in any instances, current or prior. Thanks for pointing it out, have corrected post!

dashpay / dash