fix: TODO related fixes for post-v21 release - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

fix: TODO related fixes for post-v21 release #6102

Closed knst closed 1 month ago

knst commented 2 months ago

Issue being fixed or feature implemented

Multiple TODO is reviewed and fixes in this PR

What was done?

See commits

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

PastaPastaPasta commented 1 month ago

build failed here: https://gitlab.com/dashpay/dash/-/jobs/7289203270

knst commented 1 month ago

build failed here: https://gitlab.com/dashpay/dash/-/jobs/7289203270

Restarted - succeed: https://gitlab.com/dashpay/dash/-/jobs/7298034458