dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

refactor: remove unused includes from unit tests #6112

Closed knst closed 1 month ago

knst commented 1 month ago

Issue being fixed or feature implemented

Noticed there were some not used includes in Unit tests and removed them.

It's not exhaustive list of unused headers, just something that was easy to spot.

How Has This Been Tested?

Just build and see that there's no build error.

This PR also slightly reduced compilation time of project, it's measurable big changes to6-8 seconds of one CPU core faster. Tested by compiling only files that changed in single-thread:

$ rm src/test/test_dash-blockfilter_index_tests.o src/test/test_dash-block_reward_reallocation_tests.o src/test/test_dash-denialofservice_tests.o src/test/test_dash-dynamic_activation_thresholds_tests.o src/test/test_dash-validation_block_tests.o src/test/test_dash-validation_chainstate_tests.o src/test/test_dash-validation_flush_tests.o  src/test/util/libtest_util_a-mining.o src/test/util/libtest_util_a-setup_common.o
$ cd src/test ; time make -j1

Breaking Changes

N/A

Checklist: