dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

test: disable mocktime in p2p_eviction.py #6121

Closed UdjinM6 closed 1 month ago

UdjinM6 commented 1 month ago

Issue being fixed or feature implemented

No idea why CI has no issues but p2p_eviction.py fails locally after #6103 (my guess is that it's because P2PInterface can't work with mocktime properly).

What was done?

Disable mocktime in p2p_eviction.py

How Has This Been Tested?

Run tests locally

Breaking Changes

n/a

Checklist:

UdjinM6 commented 1 month ago

ping @knst

knst commented 1 month ago

CI has no issues but p2p_eviction.py fails locally after https://github.com/dashpay/dash/pull/6103 (my guess is that it's because P2PInterface can't work with mocktime properly).

that's fun, because locally p2p_eviction.py never fails on my both machines, but p2p_timeouts.py fails badly in 80% cases on my both localhosts

PastaPastaPasta commented 1 month ago

I squashed the two commits into one; no diff