fix: avoid calling functions that change wallet state inside of `assert(...)`

[UdjinM6]

Issue being fixed or feature implemented

Functions that change the state should not be called inside asserts

kudos to @kwvg for noticing https://github.com/dashpay/dash/pull/6116#discussion_r1681163803

What was done?

Move them out

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have added or updated relevant unit/integration/functional/e2e tests
• [ ] I have made corresponding changes to the documentation
• [ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[PastaPastaPasta]

Looks fine; should we backport this or don't bother?

[knst]

Looks fine; should we backport this or don't bother?

it woks years, maybe even 10 years. I don't feel like necessary to backport