dashpay / dash

Dash - Reinventing Cryptocurrency
https://www.dash.org
MIT License
1.49k stars 1.2k forks source link

WIP: feat: immature withdrawal transactions #6128

Closed knst closed 1 month ago

knst commented 1 month ago

Issue being fixed or feature implemented

To prevent a case of catastrophic failure in case of attack on platform, withdrawals from platform is going to be immature, at least right after release.

What was done?

Make transaction of withdrawal immature, make a support for it for wallet, for rpc, and for UTXO.

How Has This Been Tested?

see updates in units tests to fix compatibility.

Though, specific tests fro withdrawals immaturity is WIP

Breaking Changes

Withdrawals becomes are immature and impossible to spend before 576 blocks are mined, similar to Coin Base transactions

Checklist:

knst commented 1 month ago

Useful changes to be merged are extracted to two new PRs: #6131 and #6141

Remaining changes are stayed non-merged, because hard-limit for 1000 dash seems sufficient enough, as discussed.