fix: build with -Wdocumentation - rename param pwallet to wallet - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

fix: build with -Wdocumentation - rename param pwallet to wallet #6142

Closed knst closed 2 months ago

knst commented 2 months ago

Issue being fixed or feature implemented

CI failures like that: https://gitlab.com/dashpay/dash/-/jobs/7400661581

It happened due to 2 PRs merged one after each other without rebasing:

enabling -Wdocumentation in bitcoin#21631 (#6113)
renaming param while doxygen comment is forgotten in #6114

What was done?

It contains changes from https://github.com/dashpay/dash/pull/6133 Thanks Vijay for spotting issue, this PR is DNM if 6133 will get merged faster.

How Has This Been Tested?

See CI

Breaking Changes

N/A

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone